Conversation
Xeonus
previously approved these changes
Jul 15, 2025
Contributor
Xeonus
left a comment
Xeonus
left a comment
There was a problem hiding this comment.
Overall LGTM, we need to add the Etherscan API key to the env variables though @jalbrekt85
| ) | ||
|
|
||
|
|
||
| def test_get_first_block_after_utc_timestamp_with_etherscan( |
| self.session.mount("https://", adapter) | ||
|
|
||
| self.last_request_time = 0 | ||
| self.rate_limit_delay = 0.2 # 200ms |
Contributor
There was a problem hiding this comment.
Free tier is 5 calls per second, so this makes sense to me
Collaborator
Author
added key in repo settings. test action will now read it in too: 7faf01b |
Xeonus
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#109 - created new
Etherscanmodule and updated the existingget_first_block_after_utc_timestampmethod to use etherscan api by default